search

hackclub / sinerider

💖 A game about love and graphing, built by teenagers.
https://sinerider.com
GNU Affero General Public License v3.0
568 stars 47 forks source link

Added new loading screen for levels #605

Closed Captainexpo-1 closed 10 months ago

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
sinerider ✅ Ready (Inspect) Visit Preview Jan 5, 2024 3:35am
Captainexpo-1 commented 1 year ago

Implements #582

polytroper commented 1 year ago

This looks perfect, except that I agree with your TODO; the "Level Loading" text needs a different style. I would actually get rid of the text and just use a three-dot ••• loading animation, like dot-flashing here: https://codepen.io/nzbin/pen/GGrXbp

polytroper commented 1 year ago

Seems we have some merge conflicts? Can you resolve those plz

polytroper commented 1 year ago

So, I notice that when I click a level that needs to load assets, the screen fades to white, but then briefly fades back to show the map and then the new loading screen fades in. Can we fix this so it fades directly to the new loading screen?

polytroper commented 11 months ago

This is so unbelievably close, but… now the screen jumps from "•••" to the selected level. It needs to fade from "•••" to selected level (as it does if you choose a level which requires no asset loading)

polytroper commented 11 months ago

Ah, but now we have introduced a new issue! The “•••” screen should only appear when there are assets to lazy-load. Now they show up every time the user clicks on a level, even if all the assets are loaded already. This breaks the clean transition that we want to have as the default experience when a level is clicked; the “•••” loading indicator is only there to tell you the game isn’t frozen in the event that assets need to load

polytroper commented 10 months ago

IT LOOKS SO GOOD!!!!