Get CI to pass - Githubissues

hackclub / site

🌈 The new, new Hack Club website (uses Next.js & Theme UI).

https://hackclub.com

Other

177 stars 143 forks source link

Get CI to pass #1153

Closed maxwofford closed 3 months ago

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 5, 2024 6:16pm

lachlanjc commented 3 months ago

📝 Changed routes:

/bin	/clubs
^{(view full size)}	^{(view full size)}

/fiscal-sponsorship/apply	/
^{(view full size)}	^{(view full size)}

/slack
^{(view full size)}

And 4 other routes:

Commit 4d3d75426ccfaa985667781edeece84ca595b118 (https://site-qbnterruu.hackclub.dev).

maxwofford commented 3 months ago

Turns out yarn format and yarn lint are 100% unrelated– I think I want to fix this in the future, but confusing we have a prettier config for code formatting, but yarn lint calls an eslint config specific to things you "shouldn't do in react" to prevent things like updating state in the wrong place. Our eslint setup also can't make fixes automatically (ie. yarn lint --fix) as far as I can tell– running it like that just spits out a list of syntax warnings.