hackclub / site

🌈 The new, new Hack Club website (uses Next.js & Theme UI).
https://hackclub.com
Other
184 stars 166 forks source link

Added UI in shop to show if an Item is Limited with Stock #1249

Closed aksinghania closed 3 months ago

aksinghania commented 3 months ago

Screenshot Preview

Screenshot 2024-06-21 at 11 10 43 PM

Added the above UI, also checked and tested to ensure the code works by using shop.json from the hack club.site website's (hardcoded data)

This addresses #1245

vercel[bot] commented 3 months ago

@aksinghania is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 7:48pm
maxwofford commented 3 months ago

This looks amazing @aksinghania! could you hide the label on quantities over 100? we have some items with lots of stock and it doesn't really matter that it's a limited quantity

Screenshot 2024-06-21 at 15 18 24
aksinghania commented 3 months ago

Sure, Working on it!

aksinghania commented 3 months ago

Done!

maxwofford commented 3 months ago

@aksinghania this is great but double check your casing for the variable name!

maxwofford commented 3 months ago
Screenshot 2024-06-21 at 15 49 43

A little bit of overlap in here!

aksinghania commented 3 months ago

Working on the overlay problem!

@aksinghania this is great but double check your casing for the variable name!

Got it, I will switch to camel Case

maxwofford commented 3 months ago

I'm merging this now because it's so great, but throw those 2 fixes up in another PR!