search

hackclub / site

🌈 The new, new Hack Club website (uses Next.js & Theme UI).
https://hackclub.com
Other
184 stars 166 forks source link

Fix color issue with banner #1259

Closed AdamTuraj closed 3 months ago

AdamTuraj commented 3 months ago

Hello, this fixes the issue mentioned in issue #1258. All I did was add the secondary color to the related tag. I attached the new color:

image
vercel[bot] commented 3 months ago

@AdamTuraj is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

IanTapply22 commented 3 months ago

Not a big fan of that fix, you shouldn't fall back on a secondary colour like that. The colour does not match the current scheme of colours for the website. We should realistically be using the primary colour for that text.

AdamTuraj commented 3 months ago

After the comment of @IanTapply22 I dug a little deeper to the cause. It seems that on a working browser, a text variable is shown as #1F2D3D. When broken it's stuck to #ffffff. I will continue to look into it and find a proper fix Working:

image

Broken:

image

Edit 1: I have been struggling to isolate the issue. For some reason it works on some peoples browsers but not others. For example I have it working in a normal tab but broken on an incognito tab. My previous fix can be disregarded especially as the component I changed is used elsewhere. When I have a chance I will continue working on this issue and hopefully be able to solve it.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
site 🛑 Canceled (Inspect) Jun 29, 2024 9:51pm