linux uppercaser not uppercaser

hackclub / some-assembly-required

📖 An approachable introduction to Assembly.

Other

3.2k stars 140 forks source link

linux uppercaser not uppercaser #77

Open yancyribbens opened 2 years ago

yancyribbens commented 2 years ago

I tested the example file uppercaser-linux-c.s although it doesn't look like it's designed to uppercaser..

from the comment section in the file uppercaser-linux-c.s

# Will print out command-line arguments and argument count

Also, it seems like while it's designed to print the number of command line arguments, it always prints -1 for every amount of arguments I feed it..

jessicard commented 2 years ago

Oh no! Thank you for catching this. Unfortunately I do not have a computer that was able to test this file when it came in, so I was unable to fully verify it working.

Some solutions:

Would you have the time to potentially fix it?
We could fix the arg count and rename the file to what it's actually doing
We can remove the file entirely (not ideal - I think any working code is useful code for Assembly stuff)

Thoughts @yancyribbens?

TheOneKevin commented 2 years ago

Hi! Could you drop the platform and compiler you used? I remember this file doesn't perform any actual uppercasing but the it should at least print the arguments. I will try to reproduce this as soon as I have time.