hackclub / sprig

🍃 Learn to code by making games in a JavaScript web-based game editor.
https://sprig.hackclub.com
MIT License
879 stars 1.03k forks source link

Gallery Image Mixup, Non New Games Have 'New' Tag #1396

Open Omay238 opened 8 months ago

Omay238 commented 8 months ago

Describe the bug Both happen in the gallery. Sometimes, games will have the wrong image, and it seems that the games at the top of the list always have the 'new' banner thing. I suspect the image issue is caused by some optimization somewhere, and the 'new' banner issue is probably because it's designed to work with sorting by date, and also it's designed to work with all games (none filtered out)

To Reproduce Steps to reproduce the behavior:

  1. Go to Gallery
  2. Search for something (I searched for all of my games)
  3. See items with 'new' banner on the top
  4. Scroll down, see items with wrong image

Expected behavior Only new games have the new banner, games have the image that is assigned to them, not the image assigned to others.

Actual behavior
Any games at the top after searching have the 'new' banner, and images sometimes show up above the wrong games.

Screenshots

Screenshot 2024-01-17 at 4 19 59 PM
Omay238 commented 8 months ago

Expected screen

Screenshot 2024-01-17 at 4 28 57 PM
JosiasAurel commented 8 months ago

the filtering issue is fixed since #1400 however I'm unable to reproduce the scenario where the images are incorrectly placed

JosiasAurel commented 8 months ago

Expected screen Screenshot 2024-01-17 at 4 28 57 PM

where did you get this expected screen btw?

Omay238 commented 8 months ago

however I'm unable to reproduce the scenario where the images are incorrectly placed

you have to type fast and scroll down fast. then the wrong images are used.

https://github.com/hackclub/sprig/assets/70179858/3f119310-46c7-4c32-a623-64d681c2901a

where did you get this expected screen btw?

i did the typing/scrolling slowly to get the right images, then used inspect to get rid of the 'new' labels

JosiasAurel commented 8 months ago

@Omay238 what browser are you using here?

Omay238 commented 8 months ago

Arc 1.26.0