hackclub / sprig

🍃 Learn to code by making games in a JavaScript web-based game editor.
https://sprig.hackclub.com
MIT License
829 stars 861 forks source link

Clutter in the top bar. #1453

Open leomcelroy opened 5 months ago

leomcelroy commented 5 months ago

These buttons getting added to the top bar are starting to clutter the interface. Please move I'm stuck, dark, and run on device to the drop down menu. Also make the drop down menu open on hover instead of click.

Screenshot 2024-02-23 at 4 24 24 PM
JosiasAurel commented 4 months ago

I think the "I'm stuck", "Run on Device" and "Share" button are quick actions that Sprig users will use often and should be maintained on the top bar.

JosiasAurel commented 4 months ago

@grymmy what do you think?

Sheepy3 commented 4 months ago

imo "run on device", "im stuck", and "share" are important to have immediately available, while dark mode and github could be relegated to a dropdown

cskartikey commented 3 months ago

Assign me the issue!

GalaxyGamingBoy commented 2 months ago

Hi! Is there any progress on this issue so far?

JosiasAurel commented 2 months ago

@GalaxyGamingBoy feel free to send a PR regarding this issue if @cskartikey hasn't done one already.

cskartikey commented 2 months ago

There's some progress, but I don't think so I'll be able to verify it until after my APs end

cskartikey commented 2 months ago

If I get time today I'll PR

grymmy commented 2 months ago

How does this issue reconcile with https://github.com/hackclub/sprig/issues/1559?

leomcelroy commented 2 months ago

Discussed this on Slack this issue should cover #1559

Cosmin-Mare commented 1 month ago

Is anyone working on this rn? if not, I can do it

JosiasAurel commented 1 month ago

you can pick it @Cosmin-Mare

Patcybermind commented 1 month ago

image hey just asking, what happened to dark mode and im stuck?

JosiasAurel commented 1 month ago

dark mode is still around. (click the brush-looking icon)

image

also "I'm Stuck" has been rebranded to "Report a bug" as the needs have changed

JosiasAurel commented 1 month ago

woops mistake

Patcybermind commented 1 month ago

ah ok then ill put that in the hover menu

Patcybermind commented 1 month ago

so i did the hover menu thing now im moving on to moving stuff to the dropdown menu but what stuff precisely should i move just the github and theme menu? image

Patcybermind commented 1 month ago

@leomcelroy what do you think about it?

Patcybermind commented 1 month ago

https://github.com/hackclub/sprig/pull/1801 this pr makes the menu open on hover