hackclub / workshops

💽 Website for Hack Club workshops.
https://workshops.hackclub.com/
MIT License
91 stars 34 forks source link

Add edit link to workshops #99

Closed jessicard closed 2 years ago

jessicard commented 2 years ago

Position is fixed so it scrolls with you.

Screen Shot 2022-04-14 at 3 47 26 PM

jessicard commented 2 years ago

Not super pumped about how it looks yet though. @exu3 do you have any ideas/advice for how this should look?

jessicard commented 2 years ago

One other question: right now it goes to https://github.com/hackclub/hackclub/tree/main/workshops/gamelab. Should it actually go to https://github.com/hackclub/hackclub/edit/main/workshops/gamelab/README.md?

jessicard commented 2 years ago

@maxwofford agreed about going directly to the edit page, done in 5b27be2

lachlanjc commented 2 years ago

📝 Changed routes:

/[slug]
Screenshot of /[slug]
(view full size)

Commit 16b0ba5f5af2b76c3d586a6321ecc1cfa8e511dc (https://workshops-2lu6rd3g5.hackclub.dev).

exu3 commented 2 years ago

Not super pumped about how it looks yet though. @exu3 do you have any ideas/advice for how this should look?

Maybe a Button or Badge reading something like "Edit this page!" with the GitHub icon?

cjdenio commented 2 years ago

Here's an idea:

image

jessicard commented 2 years ago

@exu3 Great idea!

@cjdenio That's perfect!! pls feel free to push to the branch 🙏

sampoder commented 2 years ago

This PR looks sick!! Some text on mobile is a bit difficult to read though:

Screenshot_20220415-231409_Chrome.jpg

Maybe we could remove the transparent background or make it just the icon on mobile?

jessicard commented 2 years ago

@sampoder Ooooh good catch!! I added a bg color in 72e9445.

I like the idea of potentially shortening it to just the icon. Is there another place in this app where we check for mobile/screen size you could point me to?

Screen Shot 2022-04-15 at 11 22 41 AM Screen Shot 2022-04-15 at 11 26 24 AM
sampoder commented 2 years ago

On the train rn so I don't have a super easy way of Browsing the code but check out https://theme-ui.com/sx-prop/ (the responsive values section)Screenshot_20220415-232833_Chrome.jpg

sampoder commented 2 years ago

Also for the background colour, instead of "white" let's use "background" which will change based on dark/light mode

sampoder commented 2 years ago

for responsive thing you'll want the text to have something like: display: ["none", "inline"] replace inline with what ever it currently is and it will hide on mobile but show on tablets and anything larger

jessicard commented 2 years ago

Thanks y'all! Screen Shot 2022-04-18 at 10 38 57 AM

Screen Shot 2022-04-18 at 10 38 52 AM
sampoder commented 2 years ago

YAY!