search

hackclub / yellow_pages

📒 A directory of VISA merchant IDs and categories
https://yellowpages.bank.engineering/
MIT License
5 stars 2 forks source link

[README] Document `YellowPages::Category` #30

Open garyhtou opened 2 days ago

garyhtou commented 2 days ago

We added YellowPages::Category in https://github.com/hackclub/yellow_pages/pull/26

We do have generated documentation located at https://yellowpages.bank.engineering/YellowPages/Category.html

However, it would be nice to mention the existence and maybe usage of YellowPages::Category in the README.

garyhtou commented 2 days ago

Another edit to make:

image

the gem's "branding" doesn't need to resolve around Stripe since the network ids are VISA specific, and categories should be consistent across networks (it's an ISO standard). We can and should still mention Stripe.

Also, I think the link we have on Stripe MID is incorrect since that doesn't refer to network ids.

24c02 commented 2 days ago

i think we gotta mention stripe, i'm pretty sure nobody but them uses the same keys for categories

garyhtou commented 2 days ago

Yeah, we should still mention Stripe