Add `logo` to YAML Schema

hackclub / yellow_pages

📒 A directory of VISA merchant IDs and categories

https://yellowpages.bank.engineering/

MIT License

5 stars 2 forks source link

Add `logo` to YAML Schema #4

Closed garyhtou closed 2 months ago

garyhtou commented 2 months ago

We have a schema defined here: hackclub/yellow_pages@main/lib/yellow_pages/merchants.schema.json

But, it is missing the logo field.

malted commented 2 months ago

We should remove the logo field. The gem should look up a vendored logo by the name of the merchant. See https://github.com/hackclub/yellow_pages/issues/10

malted commented 2 months ago

Closed because of https://github.com/hackclub/yellow_pages/pull/15

garyhtou commented 2 months ago

Lookups by name feel fragile. Names contain special characters/spaces and can change. Maybe we keep the logo field, but it's the file's name/relative path.