Adding chart titles from specifications

hackcollective / corona-calculator

📈 Understand the impact of social distancing measures upon Corona spread in your community

http://corona-calculator.herokuapp.com

MIT License

28 stars 15 forks source link

Adding chart titles from specifications #77

Closed fortin-alex closed 4 years ago

fortin-alex commented 4 years ago

each charts gets its own title
titles are bolded and accounts for plural
xaxis title for infection_graph() is more clear (Number of days from today vs Days)

Comments / feedback are welcomed!

Thanks!

archydeberker commented 4 years ago

Great! Thanks. Could you possibly:

make sure the titles are all the same size
optional: change the font to match the streamlit font (this is a bit demanding, sorry - the Plotly graphs have always had a different font and it just wasn't obvious because there was so little tex in them). I'm happy to do this in a followup PR

fortin-alex commented 4 years ago

make sure the titles are all the same size fixed in 7d87ad1
optional: change the font to match the streamlit font (this is a bit demanding, sorry - the Plotly graphs have always had a different font and it just wasn't obvious because there was so little tex in them). I'm happy to do this in a followup PR

Fixed in 481ec0c. I inspected the webpage and found that 2 fonts were used: Open Sans and Arial. When looking at the font, I found that Arial is more aligned with the webpage's text.

let me know if that works well for you.

fortin-alex commented 4 years ago

(someone with write access to this repository must perform the merge)