search

hackedd / gw2api

Guild Wars 2 API
MIT License
5 stars 2 forks source link

Items get_all produces invalid request url #2

Open sihrc opened 7 years ago

sihrc commented 7 years ago

gw2api.v2.items.get_all() doesn't seem to produce a valid request.

requests.exceptions.HTTPError: 400 Client Error: unable to use 'all' keyword for this API for url: https://api.guildwars2.com/v2/items?lang=en&ids=all

From the GW2 API docs:

Request the list of all available items ids when the root endpoint (v2/items) has been accessed.

Should probably be: GET https://api.guildwars2.com/v2/items?lang=en

hackedd commented 7 years ago

get_all does not work for all endpoints (because it is disabled server-side), which is why you're getting the error when you try to use it on the items endpoint.

The ID list on v2/items is handled by gw2api.v2.items.get_ids().

DeastinY commented 7 years ago

I don't really understand your answer @hackedd. Why does gw2api.v2.items.get_all() not GET https://api.guildwars2.com/v2/items?lang=en ?