search

hackerb9 / lsix

Like "ls", but for images. Shows thumbnails in terminal using sixel graphics.
GNU General Public License v3.0
3.99k stars 129 forks source link

Use correct bash shebang #16

Closed M-Gregoire closed 5 years ago

M-Gregoire commented 5 years ago

Hello,

First of all, thank you for this awesome project! Bash scripts should use the shebang #!/usr/bin/env bash for portability (See https://stackoverflow.com/a/10383546), making lsix fail on some systems.

This PR fixes the shebang to make lsix run on more *nix.

hackerb9 commented 5 years ago

Hi M-Gregoire. Thanks for the pull request! I have a minor bias against using env. While I see it as a handy kludge, I do not see it as more "correct".

Can you please tell me, is there a specific flavor of UNIX you are targeting in which you've found a problem or is this a theoretical improvement?

M-Gregoire commented 5 years ago

Hello hackerb9, I'm using NixOS where /bin/bash doesn't exists. lsix doesn't work without this PR. I believe some other Linux distros would face the same issue.

hackerb9 commented 5 years ago

Okaydoke. I still feel like env is an ugly kludge, but it seems the best solution for now. (I wish Posix would simply mandate that #!bash searches the path.)