Change the displayed label to basename of original image file

hackerb9 / lsix

Like "ls", but for images. Shows thumbnails in terminal using sixel graphics.

GNU General Public License v3.0

3.99k stars 129 forks source link

Change the displayed label to basename of original image file #26

Open catroll opened 5 years ago

hackerb9 commented 5 years ago

Basename makes sense, although I think I'd put that in processlabel() which is designed to adaptively shorten long filenames.

But why force the notofu font when not everyone will have that installed? Won't that break lsix for many people?

Also, notofu is functional but rather ugly. It is supposed to be a fallback if you have no other font that covers your Unicode range. Did you have problems with one of the other suggested fonts in the comments?

catroll commented 5 years ago

Sorry. The commit of "Change font family to Noto-Sans-CJK-SC-Regular" is my local change, pull it is a misstake. I am not really clear how to PR

hackerb9 commented 5 years ago

One way you could do it is to have your local changes in a branch of your repository. Whenever you make a change you want to share, you could do them in main and make a pull request from there. You can also pull the changes into your own local branch so they stay in sync.