search

hackerb9 / lsix

Like "ls", but for images. Shows thumbnails in terminal using sixel graphics.
GNU General Public License v3.0
4.03k stars 127 forks source link

Foot has (since version 1.8.2) reversed the meaning of DECSDM #46

Closed dnkl closed 3 years ago

dnkl commented 3 years ago

In https://github.com/hackerb9/lsix/issues/41, it was shown that enabling DECSDM, disables sixel scrolling. Something many terminals, including foot, has gotten wrong.

In 1.8.2 this was changed in foot, so that setting DECSDM now disables scrolling. Thus, lsix needs to emit \E[?80l, not \E[?80h.

Note: I guess we could start checking terminal version numbers, but thought that would just complicate the script unnecessarily. Also, I realize this is something that you may want to re-write in the future, if more terminals follow. So I opted for a small change, to make sure lsix works properly on latest foot.

hackerb9 commented 3 years ago

Closing as the problem has been "solved" in much the same way Alexander the Great "solved" the Gordian Knot: by simply cutting it out. DECSDM is no longer set (nor reset) by lsix. While not a great solution in general, it is good enough as @j4james pointed out in #41. (Also, lsix has no desire to be master of all Asia.)

dnkl commented 3 years ago

Thanks! That's a much better solution, at least for the time being.