search

hackerb9 / lsix

Like "ls", but for images. Shows thumbnails in terminal using sixel graphics.
GNU General Public License v3.0
3.97k stars 129 forks source link

Windowsconvert #48

Closed hackerb9 closed 2 years ago

hackerb9 commented 2 years ago

WIndows PATH order fix so that we never run Microsoft's "convert" program.

Once merged, this will close #42.

hackerb9 commented 2 years ago

@StaticPH Sorry to bother you again, but would you be willing to run a final test before I merge this into the main line? Also, please let me know what version(s) of Microsoft Windows you are able to test this on. Thanks!

StaticPH commented 2 years ago

Not a bother at all! Confirming that this change works perfectly for me! :+1:

Relevant environment details:

Running Windows 8.1 (64-bit) MSYS2 Bash 5.1.8(1)-release (listed as 5.1.008-1 by Pacman) Mintty 3.5.0 (listed as 1~3.5.0-1 by Pacman) TERM=xterm-256color COLORTERM=truecolor PATH=/usr/local/bin:/usr/bin:/bin:/opt/bin:/c/Windows/System32:/c/Windows:...:/d/Program Files/ImageMagick/latest:...

$> magick --version
Version: ImageMagick 7.0.10-23 Q16 x64 2020-07-04 http://www.imagemagick.org
Copyright: Copyright (C) 1999-2018 ImageMagick Studio LLC
License: http://www.imagemagick.org/script/license.php
Visual C++: 192628806
Features: Cipher DPC OpenCL
Delegates (built-in): bzlib cairo flif freetype gslib heic jng jp2 jpeg lcms lqr lzma openexr pangocairo png ps raw rsvg tiff webp xml zlib