search

hackerb9 / lsix

Like "ls", but for images. Shows thumbnails in terminal using sixel graphics.
GNU General Public License v3.0
4.03k stars 127 forks source link

Regression from #55: Alacritty-sixel error "mention attribute codes: ^[[?6c" #63

Closed gwimm closed 8 months ago

gwimm commented 1 year ago

Regression from #55

The attribute code seems to have changed for alacritty-sixel from #55's ^[[?4;6c to simply ^[[?6c or I might be doing something funny..

Demo

image

FergusFettes commented 1 year ago

I also just tried this out with the alacritty branch, same result:

Please mention device attribute codes: ^[[?6c
hackerb9 commented 1 year ago

Well, shoot. I had hoped Alacritty would have fixed this by now. Has a bug been filed with them yet?

z3ch5 commented 1 year ago

Same error sadly.. should this be fixed on the alacritty side or here? is there a way to force/trick sixl to show images on "non supported" terminal with variable or any other way ?

hackerb9 commented 1 year ago

Terminals tell programs what features they support. In particular, the attribute code 4 lets programs know that the terminal can display sixels. Alacritty at one point was correctly doing that.

There are workarounds for old, buggy terminals, but Alacritty is a modern terminal that is still developed.

z3ch5 commented 1 year ago

yes, but I would like to point here in case the others don't know, we are here about a fork of Alacritty that supports sixel, as so far I know, there is no official way (image protocol) in Alacritty to show images, so maybe the fork of Alacritty should do the feature report

hackerb9 commented 1 year ago

Thank you for the clarification. Yes, of course the fork should be responsible for the bug.

FergusFettes commented 1 year ago

Yes, I should have mentioned also. For completions sake, here is the PR: https://github.com/alacritty/alacritty/pull/4763

prurigro commented 8 months ago

Hey, I believe this can be closed as it was resolved in the maintained alacritty sixel fork @ https://github.com/ayosec/alacritty/tree/graphics (see https://github.com/alacritty/alacritty/pull/4763#issuecomment-1967601846 for details)

Thanks for lsix btw- it's a great tool!