hackerb9 / lsix

Like "ls", but for images. Shows thumbnails in terminal using sixel graphics.
GNU General Public License v3.0
4.03k stars 127 forks source link

Fix ImageMagick 6/7 compatibility #79

Closed alessandroberna closed 5 months ago

alessandroberna commented 5 months ago

Unfortunately the issue is still not fixed in the latest release. With ImageMagick 7 the warning gets printed both when using convert and magick convert: image

Since the correct way to issue the convert command seems to be using magick without the tool name, simply appending magick in front of the old command does not resolve the issue: image

I tried to keep the changes minimal:

There's no brittle version parsing and the fix does not depend on other standalone tools that may be deprecated in the future. I also made sure that the non-sixel error message prints the correct ImageMagick command.

I had to create a new PR as I did not have the permissions to re-open #73. I hope this PR addresses the issues more effectively.

hackerb9 commented 5 months ago

Thank you for filing a new pull request. I'll have to talk with the ImageMagick folks and see what their intention is for other breaking changes.