Closed satyanash closed 1 year ago
@satyanash Interesting. A book greater than 4.0 is a great indicator. We can maybe add a testcase that makes sure that the books rating has to be atleast 4. If possible we can check Amazon.com review score as well. If you are thinking of working on this issue this is what I would do.
Write a Unittest that makes sure that the book added in the last commit is in proper format. Format being
| Name | Author | Goodreads Rating | Year Published |
Add a test that make sures that the rating is >= 4.
If you have more time on this add a function to get the Amazon.com rating of the book and make sure that its above 4. Not sure how to do this really. But I think you can get the ISBN no from Goodreads API and use that to get rating from Amazon and other sites probably.
Agree with @satyanash point, it seems like a list of just books with a good rating, without any comments or thoughts. Have you (@hackerkid) read all of them? Why would one book is better than another? Because of the score?
Don't worth that much attention, as for me.
Agree with satyanash point, it seems like a list of just books with a good rating, without any comments or thoughts.
Yeah. Actually when the person creates a PR for adding the book, they are asked how many times they have read the book as well as the reasoning for adding the book to the list. I normally only merge PRs that has strong reasoning for adding the book to the list. Ofourse if you can come up with a way to enforce this rules through code feel free to do so. Also if you don't like some books that are in the list feel free to create PRs with your reasoning to remove them.
I think this repo is too opinion-based to has a name as such. Here is hierarchy, as I get it:
You (@hackerkid) accept book (PR) that:
*the column with rating in book-lists makes me believe that it matters.
Current repo description stays: "📚 Books that will blow your mind". As far as I know myself, I'm sure that my mind wouldn't blow up for at least one book from the "Humor" section. (this was a joke, there is only one book in that section, get it?)
As I suppose changing the repository name isn't an option, can you please change the description and express somewhere in the readme how you understand a purpose of this repo (Curated list of mind expanding books
not really self-containing, say from where books came from, why would they "blow someone's mind").
@b00sher That is a reasonable suggestion. Will make the necessary changes soon.
added a theater book #318
I have made many changes since the last discussion.
The description of the repo is now
Looking to find a book an interesting book to read but don't know where to start? You are in the right place!
I have also updated the CONTRIBUTING guidelines to include more details on accepting criteria.
https://github.com/hackerkid/Mind-Expanding-Books/blob/master/CONTRIBUTING.md
So closing the issue for now. Feel free to reopen.
Given that Books that will blow your mind is very subjective, it would help to define what does a book have to do, to be considered "Mind Expanding".
Given the current selection, it seems that any book that is well known and has a goodreads rating ~4.0 makes the list. If it's difficult to come up with anything else, shouldn't we at least codify this part?