search

hackerlist / glassdoor

Python API for Glassdoor.com
MIT License
81 stars 35 forks source link

False Negatives: Exact Matches in suggestions #7

Closed mekarpeles closed 10 years ago

mekarpeles commented 10 years ago 
$ glassdoor "best buy"
$ {"suggestions": ["Best Buy (exact match)", "Basic Your Best Buy", "Best Buy for Business", "Best Buy Canada", "Best Buy Travel & Tour", "Big Buy | Best Computer Store", "Cole's Best Buy Fireworks", "Best Buys General Trading"], "error": "company not found"}

The "exact match" substring may be usable as a method to reconcile failed initial lookups

kswang commented 10 years ago

still an issue for me glassdoor "Google" {"suggestions": ["Google (exact match)", "Like.com (exact match)", "Nest Labs (exact match)", "Boston Dynamics (exact match)"], "error": "company not found"}

mekarpeles commented 10 years ago

@kswang I think this problem is indeed fixed in v0.0.6, Fri 24, Jan 2014 -- Quartz. PyPI's glassdoor is currently only at v.0.0.4. I can upload the latest build later today.

kswang commented 10 years ago

downloaded v0.0.6, still had the issue. Made a quick patch

mekarpeles commented 10 years ago

Thanks! Reviewing now

On Sat, Mar 1, 2014 at 4:10 AM, kswang notifications@github.com wrote:

downloaded v0.0.6, still had the issue. Made a quick patch

Reply to this email directly or view it on GitHubhttps://github.com/hackerlist/glassdoor/issues/7#issuecomment-36423187 .