search

hackerschoice / segfault

345 stars 38 forks source link

resolves #71 #73

Closed theaog closed 1 year ago

theaog commented 1 year ago

Signed-off-by: aog theaog@users.noreply.github.com

theaog commented 1 year ago

thank you for the feedback @SkyperTHC, looking into this.

theaog commented 1 year ago

resolved max 255 length string and max 128 commands.

the sanitization check was already committed, check line 337

theaog commented 1 year ago

what if instead of adding the param we code it in the system to detect the OS and cgroup version to use the correct string?

for one it's more fun, I prefer automation over manual settings, also as CG runs in a container via compose config it removes the burden for the user to modify the compose file depending on the system they use.

what do you think?

SkyperTHC commented 1 year ago

what if instead of adding the param we code it in the system to detect the OS and cgroup version to use the correct string?

for one it's more fun, I prefer automation over manual settings, also as CG runs in a container via compose config it removes the burden for the user to modify the compose file depending on the system they use.

what do you think?

Sounds good but there should also be an option to overwrite it just in case it changes (The directory is defined by docker and they do not guarantee to keep it named like that. It will also change when we add more slices to the cgroups...so auto-detect is great but need an option just in case....)

theaog commented 1 year ago

oki doki I'll add a flag for that string, what should we call it: cgroup_path ?