Added support for transaction comments #78

hackerspace-bootstrap / strichliste-web

DEPRECATED - frontend for the strichliste api

http://demo.strichliste.org/

MIT License

11 stars 10 forks source link

Added support for transaction comments #78 #82

Closed NicoHood closed 6 years ago

NicoHood commented 6 years ago

Features:

Add optional comment field for custom transaction
Show comment for transaction overviews
Fixed: The "show all transactions" 2 (now 3) column table differs in size for the last page (issue existed before this PR already).
Hitting enter after entering custom transaction values does not work anymore -> This is a browser limitation if >=2 input fields are used. Nothing we can do about this issue

Translations for other languages have to be updated of course.

This only works with a new version of the backend of course. See https://github.com/hackerspace-bootstrap/strichliste/pull/273

schinken commented 6 years ago

Can you make it configurable with default off? Because I don't want to show something which might be incompatible with the backend as default

NicoHood commented 6 years ago

@schinken There is no need for that. I've tested the new frontend with an old backend. It will just show an empty field in the "Last 5 transactions" Table, as if nothing has changed. If you add a comment to a transaction it will simply be ignored. The complete transaction history also shows an empty column. Should be okay and compatible then. That comments do not work is expected and something I would not build a lot more if-else around.

schinken commented 6 years ago

I don't want to show something that doesn't work ;)

NicoHood commented 6 years ago

I've added a config option for the comments on custom transactions.

The comments field in the transaction overview is still enabled just because it will be blank if no comments exist, but if they do (because some other special backend wrote some etc) they will be visible. You not notice any difference unless you click "show all" (transactions) because the smaller 5 entry version has no headline anyways. You can decide i I should also disable those columns, up to you :)

NicoHood commented 6 years ago

Thanks for merging! Would you mind tagging a new release? Even if you merge the other PR as well it would be nice to have an intermediate step for debugging (if ever required) :)