search

hackerspace-ntnu / website-next

Website for the Hackerspace NTNU student organization.
3 stars 0 forks source link

build: Restructure lhci config, ignore some rules for storage pages #55

Closed ZeroWave022 closed 3 weeks ago

ZeroWave022 commented 3 weeks ago

Edited the LHCI config to use assertMatrix so we can customize what rules are enabled/disabled for each page. Why disable rules for all pages when you can disable them for the problematic pages only?

michaelbrusegard commented 3 weeks ago

This is so much better. Tell if you find out why the reports doesnt get sent back as they should. We should get linjs to websites with the reports

ZeroWave022 commented 3 weeks ago

Nothing we can do about the lighthouse reports not being uploaded, see https://github.com/GoogleChrome/lighthouse-ci/issues/1072.

Are you fine with me trying to set up a LHCI server in a Docker container on the same host that's hosting the website?

michaelbrusegard commented 3 weeks ago

Yes you can. Do it on noodlebar since that is the server we use for dev stuff. The way we do it is we have a docker compose file and all the resources needed for each individual service in its own directory in the $HOME directory. Put the docker compose and other resources in dotfiles directory in the serverspace hackerspace github repo so it can be easily viewed. DONT put secrets there just replace secrets with capital letter indicating what it is like I did for the other config files. Itsd just for a reference when people set up new servers

ZeroWave022 commented 3 weeks ago

Will set that up a separate PR, so we can get this part merged.