hackerspace-ntnu / website-next

Website for the Hackerspace NTNU student organization.
3 stars 0 forks source link

About us page and group pages #62

Open supattrw opened 5 days ago

supattrw commented 5 days ago

these is the pages that is worth to take a look at ...??

not done (but technocally same layout)

under leader and deputy leader (in devops etc.), Im thinking of using Lisa's member-component. please give me a better solution to create a table for 'list of all members' the accordion component is meant to look like the one in aboutPage the FAQ's is not done

Please be kind 😭😭😭

michaelbrusegard commented 5 days ago

Im gonna fix commit messages real quick. Next time dont use norwegian and use the conventional commit standard on all messages :)

michaelbrusegard commented 5 days ago

Cant do it because they are signed...

Fixing it by installing lazygit on your pc

michaelbrusegard commented 5 days ago

We were not able to fix all commit messages unfortunately but that is fine

michaelbrusegard commented 5 days ago

The biggest issue is that you are not reusing components. Try to create more files of smaller building blocks

michaelbrusegard commented 5 days ago

@supattrw IF you want you can focus on the main about page in this PR and the group pages can be separate PRs. I think that would be a very good idea so other people can work on the individual pages too as they finish other parts of the website

ZeroWave022 commented 2 days ago

Waiting until all of Michael's comments are resolved before submitting my own review.