search

hackerspacesg / hackerspace.sg

Hackerspace.sg 2.0 using Punch
https://hackerspace.sg/
17 stars 25 forks source link

/imgs/crest@2x.png fallback always served #107

Closed kaihendry closed 9 years ago

kaihendry commented 9 years ago

I think it's fair to say most browsers support SVG just fine. So I don't think we need the PNG fallback which gets loaded needlessly every time.

https://github.com/hackerspacesg/hackerspace.sg/blob/master/templates/css/styles.less#L14

rolandturner commented 9 years ago

Please provide quantitative evidence that at least 99% of our website sessions are by SVG-capable browsers.

On 11/11/2014 03:08 PM, Kai Hendry wrote:

I think it's fair to say most browsers support SVG just fine. So I don't think we need the PNG fallback which gets loaded needlessly every time.

https://github.com/hackerspacesg/hackerspace.sg/blob/master/templates/css/styles.less#L14

— Reply to this email directly or view it on GitHub https://github.com/hackerspacesg/hackerspace.sg/issues/107.

kaihendry commented 9 years ago

http://s.natalian.org/2014-11-11/hsg-browser-2014-11.pdf enough?

rolandturner commented 9 years ago

Are all of the browsers our visitors use (the actual versions in use, rather than the imaginary versions that would apply if all users ran the latest versions of all software at all times) capable of rendering SVG correctly?

On 11/11/2014 03:21 PM, Kai Hendry wrote:

http://s.natalian.org/2014-11-11/hsg-browser-2014-11.pdf enough?

— Reply to this email directly or view it on GitHub https://github.com/hackerspacesg/hackerspace.sg/issues/107#issuecomment-62511081.

kaihendry commented 9 years ago

I quickly drilled down into Chrome, Safari and Firefox and they are all mostly recent versions, hence I would conclude yes. The vast majority will be able to view the SVG.

Sadly Google Analytics is quite limited to "browser technology" it can drill down to:

But not SVG.

Furthermore http://caniuse.com/#feat=svg shows support being really good across everything really.

rolandturner commented 9 years ago

So, what fraction of sessions use browsers listed in caniuse.com as Supported (dark green, not olive green)?

On 11/11/2014 03:30 PM, Kai Hendry wrote:

I quickly drilled down into Chrome, Safari and Firefox and they are all mostly recent versions, hence I would conclude yes. The vast majority will be able to view the SVG.

Sadly Google Analytics is quite limited to "browser technology" it can drill down to:

  • Browser
  • Operating System
  • Screen Resolution
  • Screen Colors *Flash Version
  • Other -> Java

But not SVG.

Furthermose http://caniuse.com/#feat=svg shows support being really good across everything really.

— Reply to this email directly or view it on GitHub https://github.com/hackerspacesg/hackerspace.sg/issues/107#issuecomment-62511746.

kaihendry commented 9 years ago

The vast majority. I don't have time to figure out how to total them up with Google's baroque interface.

I couldn't find any <= IE8 users for example. http://s.natalian.org/2014-11-11/hsg-ie-2014-11.pdf

Only exception I found in Olive are a few Android users. http://s.natalian.org/2014-11-11/hsg-android-2014-11.pdf and that's partial which probably renders our simple SVG just fine.

rolandturner commented 9 years ago

Then you don't have time to remove working features from the website...

On 11/11/2014 03:39 PM, Kai Hendry wrote:

The vast majority. I don't have time to figure out how to total them up with Google's baroque interface.

I couldn't find any <= IE8 users for example. http://s.natalian.org/2014-11-11/hsg-ie-2014-11.pdf

Only exception I found in Olive in a few Android users. http://s.natalian.org/2014-11-11/hsg-android-2014-11.pdf

— Reply to this email directly or view it on GitHub https://github.com/hackerspacesg/hackerspace.sg/issues/107#issuecomment-62512321.

kaihendry commented 9 years ago

Can you prove to me this fallback is working if you are going to be so pedantic?

crest*.png is a waste of space. less is more.

rolandturner commented 9 years ago

You're proposing the change, the burden of proof is yours.

This is not a personal art work, it's a real organisation's website. Please treat it accordingly.

On 11/11/2014 03:50 PM, Kai Hendry wrote:

Can you prove to me this fallback is working if you are going to be so pedantic?

crest*.png is a waste of space. less is more.

— Reply to this email directly or view it on GitHub https://github.com/hackerspacesg/hackerspace.sg/issues/107#issuecomment-62513039.

kaihendry commented 9 years ago

I took the time to prove there will be no impact.

So you refused this on the basis there just might be a couple of Android users unable to see the image? Wowsers.

rolandturner commented 9 years ago

You asserted that you did not have time to prove, now you assert incorrectly that you proved. I feel your frustration at the need to carry ugly code, but smashing stuff that you don't like is not appropriate in this context. Save that stuff for your personal site.

On 11/11/2014 04:04 PM, Kai Hendry wrote:

I took the time to prove there will be no impact.

So you refused this on the basis there just /might/ be a couple of Android users unable to see the image? Wowsers.

— Reply to this email directly or view it on GitHub https://github.com/hackerspacesg/hackerspace.sg/issues/107#issuecomment-62514208.

valentine commented 9 years ago 
background-image: url('/imgs/crest.png');
background-image: none, url('/imgs/hsg.svg'), url('/imgs/crest@2x.png');

Let's just remove crest@2x.png? I don't see the point of giving those browsers who aren't supporting SVG's the benefit of a retina image.

icedwater commented 9 years ago

From the Notes section of http://caniuse.com/#feat=svg:

"Partial support in Android 4 refers to not supporting masking."

I think this means we can rule out SVG problems for all but IE8 users. The next step would be to find conclusive data about IE8-using visitors to our site. If this is less than 1%, I suggest we leave only the SVG.

Based on http://s.natalian.org/2014-11-11/hsg-ie-2014-11.pdf, it does seem that this is the case. Do we have figures for less recent history?

rolandturner commented 9 years ago

Sounds good.

On 11/11/2014 04:30 PM, icedwater wrote:

From the Notes section of http://caniuse.com/#feat=svg:

"Partial support in Android 4 refers to not supporting masking."

I think this means we can rule out SVG problems for all but IE8 users. The next step would be to find conclusive data about IE8-using visitors to our site. If this is less than 1%, I suggest we leave only the SVG.

— Reply to this email directly or view it on GitHub https://github.com/hackerspacesg/hackerspace.sg/issues/107#issuecomment-62516399.

valentine commented 9 years ago

I'm of the opinion that: background-image: url('/imgs/crest.png'); is still useful.

It isn't loaded by SVG-supporting browsers once the SVG is loaded. And non-SVG-supporting browsers still see something.

kaihendry commented 9 years ago

So is this bug fixed @Valentine ?

valentine commented 9 years ago

Yes, thank you. I'll close this.