hackerspacesg / hackerspace.sg

Hackerspace.sg 2.0 using Punch
https://hackerspace.sg/
17 stars 25 forks source link

Fix/adjust content for ssl #132

Closed robertsky closed 8 years ago

hyperair commented 8 years ago

I'm not sure tabbed indentation is the right thing to use. The other html files use 2 spaces for indentation.

robertsky commented 8 years ago

@hyperair changed.

chernjie commented 8 years ago

INDENTATIONS!!! runs around hysterically

robertsky commented 8 years ago

To be frank, I don't care which indentation 'standards' as long as I can run the code sanely.

On 16/11/15 10:40 AM, CJ wrote:

INDENTATIONS!!! runs around hysterically

— Reply to this email directly or view it on GitHub https://github.com/hackerspacesg/hackerspace.sg/pull/132#issuecomment-156892453.

robertsky commented 8 years ago

s/run/read

On 16/11/15 10:40 AM, CJ wrote:

INDENTATIONS!!! runs around hysterically

— Reply to this email directly or view it on GitHub https://github.com/hackerspacesg/hackerspace.sg/pull/132#issuecomment-156892453.

rolandturner commented 8 years ago

It was funnier the first time.

On 11/16/2015 10:42 AM, Robert Sim wrote:

s/run/read

On 16/11/15 10:40 AM, CJ wrote:

INDENTATIONS!!! runs around hysterically

— Reply to this email directly or view it on GitHub

https://github.com/hackerspacesg/hackerspace.sg/pull/132#issuecomment-156892453.

— Reply to this email directly or view it on GitHub https://github.com/hackerspacesg/hackerspace.sg/pull/132#issuecomment-156892665.

chernjie commented 8 years ago

As long as the indentations are consistent, especially within the same file.

hyperair commented 8 years ago

Is there a reason we're still on absolute links with references to scheme and domain, or can we use relative links?

chernjie commented 8 years ago

We should use relative links

hyperair commented 8 years ago

Any objections to merging?

notthetup commented 8 years ago

+1