Fixes to the responsive view of the website

hackerspacesg / hackerspace.sg

Hackerspace.sg 2.0 using Punch

https://hackerspace.sg/

17 stars 25 forks source link

Fixes to the responsive view of the website #56

Closed miccheng closed 10 years ago

miccheng commented 10 years ago

Fix collapsible top navbar when in mobile mode.
Add HSG SG Crest to the top left corner cos there's no logo in any of the sub pages.

valentine commented 10 years ago

I believe this kinda fixes https://github.com/hackerspacesg/hackerspace.sg/issues/15. Thanks @miccheng.

chernjie commented 10 years ago

When combined with push-state, clicking on a menu button in mobile mode does not collapse the menu while moving from one page to another.

miccheng commented 10 years ago

Oic. Hmm... Should I change these into 1 single PR?

On Monday, March 3, 2014, chernjie notifications@github.com wrote:

When combined with push-state, clicking on a menu button in mobile mode does not collapse the menu while moving from one page to another.

Reply to this email directly or view it on GitHubhttps://github.com/hackerspacesg/hackerspace.sg/pull/56#issuecomment-36459721 .

Regards,

Michael Cheng CM Mobile: +65 9185 5166 LinkedIn: http://sg.linkedin.com/in/miccheng

miccheng commented 10 years ago

Nah... The menu buttons PR should go in before this push state PR.

On Monday, March 3, 2014, Michael Cheng mcheng.work@gmail.com wrote:

Oic. Hmm... Should I change these into 1 single PR?

On Monday, March 3, 2014, chernjie notifications@github.com<javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

When combined with push-state, clicking on a menu button in mobile mode does not collapse the menu while moving from one page to another.

Reply to this email directly or view it on GitHubhttps://github.com/hackerspacesg/hackerspace.sg/pull/56#issuecomment-36459721 .

Regards,

Michael Cheng CM Mobile: +65 9185 5166 LinkedIn: http://sg.linkedin.com/in/miccheng

Regards,

Michael Cheng CM Mobile: +65 9185 5166 LinkedIn: http://sg.linkedin.com/in/miccheng

kaihendry commented 10 years ago

I didn't realise the menubar is required to be collapsible? Pretty happy the way it is. Surely making it collapsible on mobile, makes it extra fiddly?

miccheng commented 10 years ago

This was not the original intent of the designer. The menu items currently takes up all the space above the fold. Content is hidden until one scrolls down.

kaihendry commented 10 years ago

What about moving the menu to the bottom or something? Allergic to all this JS.

miccheng commented 10 years ago

No, we are using Bootstrap's CSS. This is the convention of the framework. The bottom of the screen is occupied by the Scrollback.io widget anyways. Doesn't make sense.

miccheng commented 10 years ago

By the way, i did not use the full Bootstrap JS stack... i have a customized version with only the necessary bits. We can also build a customized Jquery library with only the necessary bits.

The whole shebang can be minified into 1 condensed and compressed file as well.

notthetup commented 10 years ago

:+1:

miccheng commented 10 years ago

And chances are, the CDN edition of the JQuery file is already cached on most people's browsers - no reload required.