hackerspacesg / hackerspace.sg

Hackerspace.sg 2.0 using Punch
https://hackerspace.sg/
17 stars 25 forks source link

Change the PNG crest to Scalable Vector Graphic (SVG) #63

Closed miccheng closed 10 years ago

miccheng commented 10 years ago

Cos it looks nicer. Also added PNG fallback.

miccheng commented 10 years ago

Its a fallback strategy for browsers who don't understand the multiple background syntax. http://www.broken-links.com/2010/06/14/using-svg-in-backgrounds-with-png-fallback/

kaihendry commented 10 years ago

I noticed the SVG and PNG seem to have a SLIGHTLY different colour.

I also noticed when using my IOS iphone 5S

192.168.6.111 - GET /imgs/hsg.svg HTTP/1.1 200 842 - 4 ms
192.168.6.111 - GET /imgs/crest@2x.png HTTP/1.1 200 5593 - 3 ms

I.e. it's loading the PNG when it should be using the SVG IIUC?

miccheng commented 10 years ago

It actually loads both images... The fallback has this drawback as in it loads both images and overlay them. SVG first, then the PNG image. But you should be seeing the SVG version instead of the PNG.