Closed kaihendry closed 9 years ago
:+1: for removing scrollback. I agree it doesn't add much value.
:-1: for removing google analytics without replacing with the new Universal Analytics. It isn't that hard. Server logs are great, but we head back to the issue of who's gonna maintain a server for goaccess etc.
:+1: for zepto.
Kai,
Why are you removing scrollback.io?
On 09/11/2014 02:41 PM, Kai Hendry wrote:
You can merge this Pull Request by running
git pull https://github.com/kaihendry/hackerspace.sg noscrollback
Or view, comment on, or merge it at:
https://github.com/hackerspacesg/hackerspace.sg/pull/96
Commit Summary
remove scrollback.io and other cruft
File Changes
M templates/_footer.mustache https://github.com/hackerspacesg/hackerspace.sg/pull/96/files#diff-0 (105)
Patch Links:
- https://github.com/hackerspacesg/hackerspace.sg/pull/96.patch
- https://github.com/hackerspacesg/hackerspace.sg/pull/96.diff
— Reply to this email directly or view it on GitHub https://github.com/hackerspacesg/hackerspace.sg/pull/96.
Erm, why is Google Analytics being pulled?
On 09/11/2014 02:58 PM, Chinmay Pendharkar wrote:
:+1: for removing scrollback. I agree it doesn't add much value.
:-1: for removing google analytics without replacing with the new Universal Analytics. It isn't that hard. Server logs are great, but we head back to the issue of who's gonna maintain a server for goaccess etc.
:+1: for zepto.
— Reply to this email directly or view it on GitHub https://github.com/hackerspacesg/hackerspace.sg/pull/96#issuecomment-55227146.
As mentioned in the description, and as a longtime IRC user, it provides no utility @rolandturner
Read the description. I used hub
to create the pull request and there seems to be no way to populate the description.
@rolandturner, @notthetup: @kaihendry doesn't have access to Google Analytics, but that doesn't give him an excuse to pull Google Analytics from the site. :P
@kaihendry, please update the Google Analytics code to this.
<script>
(function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
(i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
})(window,document,'script','//www.google-analytics.com/analytics.js','ga');
ga('create', 'UA-11667249-1', 'auto');
ga('send', 'pageview');
</script>
or if anyone is feeling adventurous - Google Tag Manager:
<!-- Google Tag Manager -->
<noscript><iframe src="//www.googletagmanager.com/ns.html?id=GTM-M3BQNB"
height="0" width="0" style="display:none;visibility:hidden"></iframe></noscript>
<script>(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
'//www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
})(window,document,'script','dataLayer','GTM-M3BQNB');</script>
<!-- End Google Tag Manager -->
Just added @kaihendry and @notthetup to Analytics.
I've amended and put the GA universal snippet in there. We must submit to Google. :smiley_cat:
Must. Have. Data. :information_source:
@kaihendry may I suggest you break down this commit to three different pull request? ga, davis, and scrollback.io
Smaller atomic pull request get merged faster
@chernjie no, it will be faster if you merge it right now. These changes are trivial.
On 09/11/2014 03:07 PM, Kai Hendry wrote:
As mentioned in the description, and as a longtime IRC users, it provides no utility @rolandturner https://github.com/rolandturner
Apologies, the description didn't appear in the email (something is presumably broken somewhere). So:
scrollback.io and davis is slowing down the site. This is especially apparent on the mobile site. This is a purge of it to make the site faster.
We have tried scrollback.io over the last year. I for one think it has brought zero utility. There are better Web logging applications, e.g. https://botbot.me/ There are better Web IRC clients https://news.ycombinator.com/item?id=8285832
google analytics was removed too since this is the older slower method and should be probably using its new Universal API or just use the server logs, e.g. with http://goaccess.io/
I also took the liberty of updating jquery. Though we should probably replace jquery with the even saner http://zeptojs.com/
If Scrollback is integrated correctly, it can't slow the site down. It's not aimed at longtime IRC users (who presumably already have IRC clients that they'd prefer to use) but at casual users who aren't interested in running yet another client. That latter category includes me so, no, the utility is not zero.
I note that the pull has happened, can we please undo this?
@rolandturner it does slow the site down. Have a look at the paint refreshes in Google chrome dev tools and its esp bad on mobile.
If you need a Web client, (i.e. you don't want to install an IRC client locally I'll happily help setup a Web IRC client like shout. In the interim there is http://webchat.freenode.net/
I can add a data point as someone who's quite regularly in the IRC room.
I have yet to have a conversation with anyone who ended up on the #hackerspacesg IRC channel using scrollback.io. Most scrollback.io users usually just say "hello" and soon leave the room.
Point being it hasn't really added much interactivity to the website or hasn't gotten new regulars to our hackerspacesg channel.
I noticed that the mailing list was cc'ed by @rolandturner. Goodness!
I agree with the removal of Scrollback widget. We can continue to link to Scrollback directly, but the widget should go!
On 09/11/2014 09:25 PM, Chinmay Pendharkar wrote:
I can add a data point as someone who's quite regularly in the IRC room. I have yet to have a conversation with anyone who ended up on the #hackerspacesg IRC channel using scrollback.io. Most scrollback.io users usually just say "hello" and soon leave the room.
That does point to Scrollback not being a good fit for HackerspaceSG. The intention is specifically to allow non-IRC-users easy (non-'90s-refugee-web-interface) access to IRC users within communities for whom this this technology barrier is an issue. If we're not actually having meaningful conversations happen this way then my occasional use of it is perhaps insufficient to warrant retaining it.
Thanks.
scrollback.io and davis is slowing down the site. This is especially apparent on the mobile site. This is a purge of it to make the site faster.
We have tried scrollback.io over the last year. I for one think it has brought zero utility. There are better Web logging applications, e.g. https://botbot.me/ There are better Web IRC clients https://news.ycombinator.com/item?id=8285832
google analytics was removed too since this is the older slower method and should be probably using its new Universal API or just use the server logs, e.g. with http://goaccess.io/
I also took the liberty of updating jquery. Though we should probably replace jquery with the even saner http://zeptojs.com/