Change the color of a rectangle like a line

hackerwins / codepair-old

Real-time markdown editor for interviews, meetings and more...

https://codepair-old.yorkie.dev

Apache License 2.0

90 stars 29 forks source link

Change the color of a rectangle like a line #125

Closed ppeeou closed 3 years ago

ppeeou commented 3 years ago

What this PR does / why we need it?

we can change color of rect

but we can not control order each rect when user select rect to solve above issue, we have to solve this issue ref

Any background context you want to provide?

What are the relevant tickets?

Fixes #111

Checklist

[x] Added relevant tests or not required
[x] Didn't break anything

ppeeou commented 3 years ago

I plan to proceed with this PR after applying the yorkie-js-sdk to the issues below

https://github.com/yorkie-team/yorkie-js-sdk/issues/225

ppeeou commented 3 years ago

Thanks for your contribution. Overall good. I leave a brief comment.

How about painting only the border color of the rectangle? For example, when drawing the architecture of a project, it would be useful to color only the border rather than the fill.

thank you for your comment:) I did it :)

this PR should be merged after PR merge

hackerwins commented 3 years ago

@ppeeou Please fix the conflicts.

ppeeou commented 3 years ago

fixed it :)