search

hackerwins / codepair-old

Real-time markdown editor for interviews, meetings and more...
https://codepair-old.yorkie.dev
Apache License 2.0
90 stars 29 forks source link

need to make development environment same. #137

Closed starkensin closed 3 years ago

starkensin commented 3 years ago

Eenvironment(local): npm: 6.14.14 node: 14.17.5

Description: When I install dependencies using "npm install" command, the "package-lock.json" file is updated unlike the existing one.

image

Why: As we can check the lockFileVersion is different on the above image, I guess this problem is from the development environment is different on person.

Related issue: issue #136

ppeeou commented 3 years ago

I think it would be better for users to adapt to the repo environment.

to solve this problem, How about providing the development environment in the README or creating a Docker file??

starkensin commented 3 years ago

I cast a vote for Dockerfile!

blurfx commented 3 years ago

If no one is working on it, I'd love to write a Dockerfile.

Also, it would be good to add .tool-versions for asdf users.

ppeeou commented 3 years ago

If no one is working on it, I'd love to write a Dockerfile.

we'd appreciate it if you did

starkensin commented 3 years ago

We missed that docker environment cannot solve this problem. When we add additional library through npm system on local development environment, depending on contributor's node.js(npm) version, it could change package-lock.json.

Therefore, I will remove docker development environment and write required node.js(npm) version on readme.md.