search

hackerwins / codepair-old

Real-time markdown editor for interviews, meetings and more...
https://codepair-old.yorkie.dev
Apache License 2.0
90 stars 29 forks source link

Use yorkie metadata #143

Closed ppeeou closed 3 years ago

ppeeou commented 3 years ago

What this PR does / why we need it?

Use yorkie's metadata function https://github.com/yorkie-team/yorkie-js-sdk/pull/236

Any background context you want to provide?

sdk version is not yet on the release version, so it will be applied after release distribution.

What are the relevant tickets?

Fixes #140

Checklist

hackerwins commented 3 years ago

@ppeeou There seems to be a bug where the line color doesn't change. Can you find out the cause?

hackerwins commented 3 years ago

@ppeeou. The bug mentioned above are no longer reproducible. Maybe it has something to do with the commit that you edited? https://github.com/yorkie-team/yorkie-codepair/pull/143#pullrequestreview-786351351

ppeeou commented 3 years ago

@ppeeou. The bug mentioned above are no longer reproducible. Maybe it has something to do with the commit that you edited? #143 (review)

Hmm.. it doesn't seem to have anything to do with my edit. I'm still testing but haven't seen the same error..

hackerwins commented 3 years ago

@ppeeou I couldn't find the reproduce path of the bug, but I found that the bug was intermittently occurring when I opened both windows and tested the drawing. Perhaps it is an error that has nothing to do with this PR. It seems to have something to do with changing the order of the rects.

The line color bug is 100% reproducible. please check: https://github.com/yorkie-team/yorkie-codepair/pull/143#issuecomment-951962479

ppeeou commented 3 years ago

The line color bug is 100% reproducible. please check: #143 (comment)

I fixed it https://github.com/yorkie-team/yorkie-codepair/pull/143/commits/f221763b82e28049a7f763fcf47bb7d4b1ca48bb

I fixed this issue in another PR, but it's better to fix it here...

ppeeou commented 3 years ago

I couldn't find the reproduce path of the bug, but I found that the bug was intermittently occurring when I opened both windows and tested the drawing. Perhaps it is an error that has nothing to do with this PR. It seems to have something to do with changing the order of the rects.

you mean maybe we can find bug #125 right?

hackerwins commented 3 years ago

The line color bug is 100% reproducible. please check: #143 (comment)

I fixed it f221763

I fixed this issue in another PR, but it's better to fix it here...

Yes. Because PR will be released as soon as the PR is merged, it should be bug-fixed.