search

hackerwins / codepair-old

Real-time markdown editor for interviews, meetings and more...
https://codepair.yorkie.dev
Apache License 2.0
90 stars 29 forks source link

Make Vim command input pretty #148

Closed hackerwins closed 2 years ago

hackerwins commented 2 years ago

Description:

Make Vim command input pretty.

We provide Vim mode using CodeMirror's vim binding.

Screen Shot 2021-10-21 at 3 48 05 PM

When we type :, Command Input appears, but it doesn't come out as pretty as the one below.

Screen Shot 2021-10-21 at 3 48 41 PM

Why:

eddie0329 commented 2 years ago

Hello @hackerwins. I worked on this issue like below:

Before After
스크린샷 2022-01-24 오후 12 08 54 스크린샷 2022-01-24 오후 12 08 00

If it looks ok, I will open PR!

Thank you. And have a nice day.

hackerwins commented 2 years ago

@eddie0329 Thanks for the experiment. It looks better than before. Could you create a PR for this?

eddie0329 commented 2 years ago

@hackerwins Thanks for reply! :)

Before creating PR, is there any contirbution guide for codepair?

I can see other contribution guides which were included in other respository within yorkie-team, but cannot find in codepair repository.

hackerwins commented 2 years ago

@eddie0329 I forgot that there is no contribution guide on this repository(Thank you for letting me know).

Please refer to the guide in other repo: https://github.com/yorkie-team/yorkie-js-sdk/blob/main/CONTRIBUTING.md