Closed shmruin closed 2 years ago
@shmruin Sorry for the late reply🙇
It seems that you can procced unrelated to PR #143, However, the version should be yorkie 0.1.8 or higher. If you end works first, I would rebase code, and If abstraction is necessary, we would do it at that time
Instead of showing the text input window right away, how about making a button to display a text bar ??🤔
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
This PR is stale, so I'm closing it.
What this PR does / why we need it?
Current username consists of anonymous animal name. This is useful, but sometimes users may need to change their name to identify theirselves.
Any background context you want to provide?
This is draft PR of this issue, as I am faced with a few problems.
Client.UpdateMetadata
is necessary for this process, maybe in thepeerSlice
. Guess some kind ofUpdateMetadata
action should change the username when the textInput of the username is onBlur, but is it related to the PR #143 ? and need to wait until that is completed?Any review on code or opinions would be very helpful. Thanks.
What are the relevant tickets?
Fixes #129
Checklist