hackerwins / codepair-old

Real-time markdown editor for interviews, meetings and more...
https://codepair-old.yorkie.dev
Apache License 2.0
90 stars 29 forks source link

Support changing self username on code-pair #149

Closed shmruin closed 2 years ago

shmruin commented 3 years ago

What this PR does / why we need it?

Current username consists of anonymous animal name. This is useful, but sometimes users may need to change their name to identify theirselves.

Any background context you want to provide?

This is draft PR of this issue, as I am faced with a few problems.

  1. Client.UpdateMetadata is necessary for this process, maybe in the peerSlice. Guess some kind of UpdateMetadata action should change the username when the textInput of the username is onBlur, but is it related to the PR #143 ? and need to wait until that is completed?
  2. Any user process opinions. onClick event of clicking the avatar is already assigned to the action of showing userlist view, so I'm not sure when to show this text input. Or just always-showing mode of text input is enough?

Any review on code or opinions would be very helpful. Thanks.

What are the relevant tickets?

Fixes #129

Checklist

ppeeou commented 3 years ago

@shmruin Sorry for the late reply🙇

  1. It seems that you can procced unrelated to PR #143, However, the version should be yorkie 0.1.8 or higher. If you end works first, I would rebase code, and If abstraction is necessary, we would do it at that time

  2. Instead of showing the text input window right away, how about making a button to display a text bar ??🤔

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

hackerwins commented 2 years ago

This PR is stale, so I'm closing it.