search

hackerwins / codepair-old

Real-time markdown editor for interviews, meetings and more...
https://codepair.yorkie.dev
Apache License 2.0
90 stars 29 forks source link

Check development environment. #151

Closed starkensin closed 2 years ago

starkensin commented 2 years ago

Description: Check development environmen on local development environment. (e.g husky) Why: When node.js(npm) version doesn't sync among contributors, it brings in some problems like #137 issue.

starkensin commented 2 years ago

I think only checking node version using husky is not that good. Husky checks hooks when a contributor commits code to git system. If it only check node version, it cannot check which node.js(npm) version made package-lock.json.

Therefore it seems to need to check packge-lock and nodejs(npm) both.

starkensin commented 2 years ago

last weekly meet-up session(Oct 31), "preinstall" is suggested for the solution. While I've researched the method to check node.js and npm version, I found "engines" feature of package.json and ".npmrc" file. I think using these is the best solution. I will apply this way.