search

hackerwins / codepair-old

Real-time markdown editor for interviews, meetings and more...
https://codepair-old.yorkie.dev
Apache License 2.0
90 stars 29 forks source link

apply yorkie-js-sdk v0.2.8 #185

Closed Eithea closed 2 years ago

Eithea commented 2 years ago

What this PR does / why we need it?

change interface name to apply : https://github.com/yorkie-team/yorkie-js-sdk/commit/47478e73a91634c15055adb1dfc0977e8656a5f0

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

hackerwins commented 2 years ago

Thanks for your contribution.

For this task, we need to update the JS SDK to v0.2.8. https://github.com/yorkie-team/codepair/blob/main/webapp/package.json#L58

Eithea commented 2 years ago

there is a bug about undo : If a client do 'undo' twice, the other clients receive wrong value. But i could not find the cause.

hackerwins commented 2 years ago

@Eithea Thanks for the report. I couldn't reproduce the bug. Could you register the bug as a new issue?