search

hackerwins / codepair-old

Real-time markdown editor for interviews, meetings and more...
https://codepair.yorkie.dev
Apache License 2.0
90 stars 29 forks source link

Update package-lock.json #202

Closed metleeha closed 2 years ago

metleeha commented 2 years ago

Delete deprecated lib "node-sass" & Add latest "sass"

What this PR does / why we need it

Since lib-sass and node-sass have been deprecated, they fall back to the dart-sass.

Any background context you want to provide?

I installed 1.53.0, the most recent version that can be found in the dart-sass github repo. Since I could not find any code used by importing the node-sass library, I didn't modify any other code.

What are the relevant tickets?

Fixes #196

Checklist

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

blurfx commented 2 years ago

Hmm. It might be helpful to use npm ci command instead of npm install on github action workflow.

blurfx commented 2 years ago

Would you like to delete node_modules and package-lock.json, and run npm install locally, and commit? [ref]

metleeha commented 2 years ago

I deleted the package-lock.json and node-modules file, reinstalled it with the npm i -D fsevents command, and committed it.

blurfx commented 2 years ago

Great 👍 . Could you resolve the conflict? I think you can just use the new package-lock.json.