hackerwins / codepair-old

Real-time markdown editor for interviews, meetings and more...
https://codepair.yorkie.dev
Apache License 2.0
90 stars 29 forks source link

fix to handle links with fragments #283

Closed degurii closed 1 year ago

degurii commented 1 year ago

What this PR does / why we need it?

Fixes URL link navigation with fragments not working properly.

Any background context you want to provide?

In my opinion, when a link contains a fragment in the code mirror, it seems that we cannot retrieve the text including the fragment using token.string. However, since the entire link is wrapped in a link-type span element, I have made changes to extract the url from the element, enabling proper navigation to the correct link.

What are the relevant tickets?

Fixes #248

Checklist

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.