hackforla / 311-data

Empowering Neighborhood Associations to improve the analysis of their initiatives using 311 data
https://hackforla.github.io/311-data/
GNU General Public License v3.0
62 stars 63 forks source link

Add NC name pill to Search and Filters modal on address selection #1813

Closed ryanfchase closed 1 month ago

ryanfchase commented 1 month ago

Overview

We need to render the relevant neighborhood council's name as a pill when the user selects an address so that users know what neighborhood council that address is in.

Action Items

Resources/Instructions

Useful Files and Components

v1.2 Moderated Usability Test Slideshow:

Screenshot before proposed changes

![image](https://github.com/user-attachments/assets/ec297a87-651e-454e-8cc6-549b82a2adc3)

Screenshot after proposed changes

![image](https://github.com/user-attachments/assets/0ede2cea-6533-40d4-bcb1-c9388b8c93ef)

ryanfchase commented 1 month ago

This ticket is ready for dev lead review -- I'm unsure if this is a Good First Issue. If so, I can add more instruction to support the new dev in completing the ticket.

traycn commented 1 month ago

Reviewed and ready for priotization.

ryanfchase commented 1 month ago

This ticket has been prioritized and is ready to be picked up 👍

Brandoncyu commented 1 month ago

Taking this on. Hoping to get it done by Saturday, September 14

Brandoncyu commented 1 month ago

PR is opened: https://github.com/hackforla/311-data/pull/1825

Sending to @ryanfchase and @traycn for review

ryanfchase commented 1 month ago

Adding my review soon, eta late afternoon. Checking out the branch, the behavior is looking good:

Selecting an address also selects the NC

![image](https://github.com/user-attachments/assets/033671de-40b8-46dc-b1a9-27a4a76054c0)

@Brandoncyu for future reference, modify the PR contents so that "issue number here" gets populated. This is the only real requirement for PR issue-formatting for our team at the moment. It becomes a dynamic link and makes it easy to navigate. Thanks.

"Issue number here" location

![image](https://github.com/user-attachments/assets/f1a0ac50-8912-420b-a6b3-6a0b1ac13f3a)

ryanfchase commented 1 month ago

Just adding one request for change in my review. Please make the adjustment, or state an alternative approach. Thanks.