hackforla / 311-data

Empowering Neighborhood Associations to improve the analysis of their initiatives using 311 data
https://hackforla.github.io/311-data/
GNU General Public License v3.0
62 stars 63 forks source link

Make font types in search and filters modal consistent #1815

Closed ryanfchase closed 2 months ago

ryanfchase commented 2 months ago

Overview

We need to make fonts on the search and filters modal consistent so users don't get confused about how the modal works

Action Items

Collapsible Sections

ADD: Header class style for "Boudaries" ``` header: { fontSize: '12.47px', fontWeight: theme.typography.fontWeightMedium, marginBottom: '8px', }, ```
DELETE: Label class style for "Boundaries" ``` label: { display: 'inline-block', font: theme.typography.b2, marginBottom: '10px', color: theme.palette.secondary.light, }, ```
ADD: useStyle const for "Date Range" ``` const useStyles = makeStyles(theme => ({ header: { fontSize: '12.47px', fontWeight: theme.typography.fontWeightMedium, marginBottom: '8px', }, })); ```

Resources/Instructions

Screenshot before proposed changes

![image](https://github.com/user-attachments/assets/592ff5bf-a5bc-454a-a61f-fa831a436c5e)

Screenshot after proposed changes

![image](https://github.com/user-attachments/assets/85c9c00a-d0ca-45b7-9266-619fe71fa326)

ryanfchase commented 2 months ago

Ready for dev lead. I think it's a "Good First Issue". Happy to add more in-depth instruction if required.

traycn commented 2 months ago

Reviewing as dev lead: ETA - 9/8 Time - 12pm PT

traycn commented 2 months ago

Updated Action Items with file loc, line, and implementation for "Boundaries" and "Date Range" titles in the search/filter map modal.

Comment on my findings:

Style implementation for each title is inconsistent across the 3 Titles in the modal. To introduce consistency, I've proposed a solution to use the useStyle for each file to be consistent with how the style title "Request Types" is implemented.

IMPORTANT NOTE:

Use style has been deprecated since 2021 and is now Legacy. It is not recommended for use. Link to useStyle docs here.

Issue created to address deprecated @mui/style - https://github.com/hackforla/311-data/issues/1820

traycn commented 2 months ago

Updated the description a second-time. Issue previously did not update with the detailed action items points.

ryanfchase commented 2 months ago

This ticket has been prioritized and is ready to be picked up 👍

Brandoncyu commented 2 months ago

Updates have been made: image

Brandoncyu commented 2 months ago

PR has been made: https://github.com/hackforla/311-data/pull/1821