Closed ryanfchase closed 2 months ago
Ready for dev lead. I think it's a "Good First Issue". Happy to add more in-depth instruction if required.
Reviewing as dev lead: ETA - 9/8 Time - 12pm PT
Updated Action Items with file loc, line, and implementation for "Boundaries" and "Date Range" titles in the search/filter map modal.
Style implementation for each title is inconsistent across the 3 Titles in the modal. To introduce consistency, I've proposed a solution to use the useStyle
for each file to be consistent with how the style title "Request Types" is implemented.
Use style has been deprecated since 2021 and is now Legacy. It is not recommended for use. Link to useStyle docs here.
Issue created to address deprecated @mui/style
- https://github.com/hackforla/311-data/issues/1820
Updated the description a second-time. Issue previously did not update with the detailed action items points.
This ticket has been prioritized and is ready to be picked up 👍
Updates have been made:
PR has been made: https://github.com/hackforla/311-data/pull/1821
Overview
We need to make fonts on the search and filters modal consistent so users don't get confused about how the modal works
Action Items
[x] Grab the color, font size, and font weight for "Request Types" in the Search and Filters Modal
/components/main/Desktop/TypeSelector/index.js
, line: 22, 83[x] Apply that color, font size, and font weight to "Boundaries"
/components/main/Desktop/CouncilSelector/index.js
classes.label
toclasses.header
for "Boundaries" title[x] Apply that color, font size, and font weight to "Date Range"
componenets/DataSelector/DataSelector.jsx
import useStyle from ...
import makeStyles from '@mui/styles/makeStyles';
span
todiv
for the title valueDate Range
className={label}
toclassName={classes.header}
Collapsible Sections
ADD: Header class style for "Boudaries"
``` header: { fontSize: '12.47px', fontWeight: theme.typography.fontWeightMedium, marginBottom: '8px', }, ```DELETE: Label class style for "Boundaries"
``` label: { display: 'inline-block', font: theme.typography.b2, marginBottom: '10px', color: theme.palette.secondary.light, }, ```ADD: useStyle const for "Date Range"
``` const useStyles = makeStyles(theme => ({ header: { fontSize: '12.47px', fontWeight: theme.typography.fontWeightMedium, marginBottom: '8px', }, })); ```Resources/Instructions
Screenshot before proposed changes
![image](https://github.com/user-attachments/assets/592ff5bf-a5bc-454a-a61f-fa831a436c5e)
Screenshot after proposed changes
![image](https://github.com/user-attachments/assets/85c9c00a-d0ca-45b7-9266-619fe71fa326)