Closed ryanfchase closed 1 month ago
Ready to be picked up
Pull request has been opened: https://github.com/hackforla/311-data/pull/1832
@Brandoncyu I've provided a review with request for a small change to the asset URLs.
Also, notes on ticket management:
Prioritized Backlog
to In Progress
.In Review
.Thanks Brandon!
@Joy-Truex @allisonjeon can we get a review on the dev's implementation? A screenshot is available here:
![image](https://github.com/user-attachments/assets/50d29ef1-fd67-4b4e-a160-08c2223b18da)
I'm wondering if its worth coming up with a system for design leads to review dev's implementations before it gets merged. Perhaps we can talk about this tonight. Maybe a process for dropping screenshots into the Figma so design lead can quickly inspect and compare it to the original designs.
Moving to In Review while waiting for design lead to have a look.
Here are my notes:
TY!
@Joy-Truex wanted to ask what a "hug" is? And if you have any instruction for inserting this into HTML?
@Brandoncyu basically it means the object should resize on a larger/smaller device size not just stay static.
I have added the new dots:
Great! are you able to update the font to the specifications here?
just did:
Thanks all. I've approved the PR, I believe it satisfies requests made during QA.
Can you ensure the font is Roboto? It looks like it may be times new roman?
It is Roboto:
Will it show up differently in the email than it does in this screenshot? Roboto is a sans serif font and the font in the screenshot is serif. Sorry if I'm missing something, ty!
@ryanfchase can you confirm?
Good catch @Joy-Truex, and indeed @Brandoncyu is specifying it correctly in the code. However, it seems that we cannot use web fonts in our emails. At least, according to the guide I attached. I think we'll need to pick from the list that the Gmail text editor allows.
- Sans Serif (Arial) - Serif (Times New Roman) - Fixed Width (monospace) - Wide (Arial Black) - Narrow (Arial Narrow) - Comic Sans MS - Garamond - Tahoma - Trebuchet MS - Verdana
![image](https://github.com/user-attachments/assets/c9caf9e8-33da-49e4-9413-b86175b042c1)
Ahhh okay that explains it.
Please proceed with Sans Serif (Arial)
(updated with a comment in the original ticket)
thank you both!
Changed has been made.
Overview
Design team has created an email template design and now we need to implement it for our Contact Page emails.
Action Items
311-data/templates
311-data/templates/contact-us.html
contact-us.html
, do not use external style sheets (see R1)Screenshot after proposed changes
section of this postResources/Instructions
Figma Info
Screenshot before proposed changes
n/a
Screenshot after proposed changes
![image](https://github.com/user-attachments/assets/80f83227-d892-40bc-980f-f05f48b2edab)