hackforla / 311-data

Empowering Neighborhood Associations to improve the analysis of their initiatives using 311 data
https://hackforla.github.io/311-data/
GNU General Public License v3.0
62 stars 64 forks source link

Fix Filter modal's date range buttons style not being applied #1835

Closed traycn closed 1 month ago

traycn commented 1 month ago

Overview

We need to apply styling on the pre-defined date range buttons in the Filters modal, to have the Last Week, Last Month, Last 3 Months buttons styled.

Action Items

Resources/Instructions

[Replace this text - Provide these resources here if exist. Provide screenshot only if the issue has visual changes on the site, do not post screenshots of codebase]

Screenshot before proposed changes

![Screen Shot 2024-09-25 at 7 33 44 PM](https://github.com/user-attachments/assets/b96e01bd-d7f0-4e39-b089-c8cf165b15aa)

Screenshot after proposed changes

![image](https://github.com/user-attachments/assets/744f7417-e66b-490a-a508-6ee81d3b059d)

ryanfchase commented 1 month ago

@traycn this is looking good. When you're ready, remove draft and add ready for prioritization.

ryanfchase commented 1 month ago

My edits to the page: added link to the Figma page. Also adding Milestone.

ryanfchase commented 1 month ago

Prioritized and ready to be picked up!

Brandoncyu commented 1 month ago

PR has been made: https://github.com/hackforla/311-data/pull/1838

ryanfchase commented 1 month ago

@traycn I'm going to OK this to get approved. This is a new idea, but I feel like 1pt Size and under probably can just use 1 review. This should alleviate both of us needing to watch every single PR moving through.

Brandoncyu commented 1 month ago

I will wait til @traycn gives the ok before merging.

traycn commented 1 month ago

Approved! Moving the styles to the seperate file was a great change. Taking note that we are referencing styles for the DateSelector dropdown at: components/DateSelector/useStyles.js

Feel free to merge @Brandoncyu