Open Aveline-art opened 2 years ago
@jenchuu Hi jen! I did not see the component in the design system in Figma, so I am not sure if it is finalized. Once it is, feel free to swap the role labels back and throw this back to development.
Hey @fenglugithub, can you help me with this issue. Are the components that Ava is referring to in the Design System on Figma? I looked but I couldn't be 100% sure. TY!
I was going through the questions/review column of the project board and was curious about this task so I investigated it.
Not sure how up to date this is, but I found an input component in the figma design system here:
Here is a screenshot of the Input component Ava is referring to:
Notes
TextField
) is only used in the /demo
page.
frontend/src/pages/Demo.tsx
)http://localhost:8000/demo
demo
page is only there to test frontend components. It is not a real page we would show to users. frontend/src/tw-components/TextField.tsx
TextField
component. Hers was made with SCSS. It is located in frontend/src/components/Inputs/Textfield.tsx
In my opinion, we should just remove Ava's TextField
component entirely from the frontend and use the tw-component Matt made. We only need one and the tailwind one is better, plus we are already using it.
Removing Ava's component to reduce redundancy would be a good first issue for a frontend developer. This would remove unnecessary code and shrink our final frontend application bundle size.
Removing any old, unneeded, non-tailwind components (in the frontend/src/components
folder) would be helpful to clean up the codebase. It should be okay to remove them if they are not used anywhere else, and if there is already a tw-component for it. This can be another potential first issue for a frontend developer.
Eventually we also want to make sure the final build does not include the demo
route. We can either remove it entirely or maybe comment it out of the react router if we want to keep it.
Overview
As a developer we need to develop components that help us reuse code. For this issue, we will make the input component on the login page.
Action Items
Designers
Resources/Instructions
Resources