NavMobile landing page side bar links

hackforla / HomeUniteUs

We're working with community non-profits who have a Host Home or empty bedrooms initiative to develop a workflow management tool to make the process scalable (across all providers), reduce institutional bias, and effectively capture data.

https://homeunite.us/

GNU General Public License v2.0

36 stars 21 forks source link

NavMobile landing page side bar links #602

Closed mira-kine closed 2 months ago

mira-kine commented 8 months ago

Closes #579

What changes did you make?

Added href to list item button in the drawer as well

Rationale behind the changes?

current link was only used in the HUU Logo button, not the hamburger menu drawer

What did you learn or can share that is new?(optional)

coordinator/host icon responsiveness will be changed in another issue
nav mobile has both hamburger and HUU icon working as nav (maybe a merge bug?). Since issue #552 was about replacing hamburger menu with HUU icon, I think this is another bug but wanted to make sure since I see a double menu proposal on Figma as well.

Visuals before changes are applied

[Original Bug](https://hackforla.slack.com/files/UJK101BKL/F05PV6ELW3B/huu-mobilenavbarbug.mp4)

Visuals after changes are applied

https://github.com/hackforla/HomeUniteUs/assets/90009901/fc1cebf8-7e8b-4d56-8cdf-133422bf251c

Joshua-Douglas commented 2 months ago

Hey @tylerthome, @erikguntner,

It looks like we accidentally merged this PR with a failing CI pipeline. Can we add some branch protections to require the status checks to pass?

I'll submit a fix for this in #668.

Thanks!

JpadillaCoding commented 2 months ago

@Joshua-Douglas Do you believe this is what may be causing other PR checks to fail? I've been experiencing failures and couldn't figure out why and I see that your checks have now turned into failures too.

Joshua-Douglas commented 2 months ago

Hey @JpadillaCoding, Yes it is! I took a look at your pipeline failure on PR #671 and I can confirm it is the same issue.

I fixed the error in 74f861e. You should be able to cherry-pick this commit onto your branch to fix the error. Or you can wait for my PR to be merged and then merge with main. Both options work!

JpadillaCoding commented 2 months ago

@Joshua-Douglas Yup that fixed it for me! Nice job figuring this out and I also got to learn about git cherry-pick which was neat too 😄

Joshua-Douglas commented 2 months ago

That's awesome!!