hackforla / HomeUniteUs

We're working with community non-profits who have a Host Home or empty bedrooms initiative to develop a workflow management tool to make the process scalable (across all providers), reduce institutional bias, and effectively capture data.
https://homeunite.us/
GNU General Public License v2.0
35 stars 21 forks source link

578 adding alchemy auto schema #648

Closed stevbark closed 2 months ago

stevbark commented 3 months ago

Closes #replace_this_text_with_the_issue_number

What changes did you make?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied ![image](Paste_Your_Image_Link_Here_After_Attaching_Files)
Visuals after changes are applied ![image](Paste_Your_Image_Link_Here_After_Attaching_Files)
stevbark commented 3 months ago

Issue described here: https://github.com/hackforla/HomeUniteUs/issues/578

JpadillaCoding commented 3 months ago

Hey @stevbark I'm taking a look into your PR and was trying to figure out a way to test the schemas. How were you approaching testing?

stevbark commented 3 months ago

Hey @stevbark,

Thanks for adding this! I agree with @JpadillaCoding, can you write a couple of test cases that:

  • demonstrate using marshmallow_sqlalchemy to serialize a Host and HousingProgramServiceProvider database object to JSON
  • demonstrate using marshmallow_sqlalchemy to deserialize JSON into a Host and HousingProgramServiceProvider?

It'll be easier to write these types of tests once my PR is merged, but the current pytest proj has most or all of what you need now.

What file should the test be in? In the controller or the Utils test file?

stevbark commented 2 months ago

Resolved issues. all tests passed before. Pushed the gitignore update and the tests started failing. not sure why.

erikguntner commented 2 months ago

@stevbark yeah that's weird. I re-ran the tests and they passed.

erikguntner commented 2 months ago

@Joshua-Douglas can you confirm that the changes you requested were made? If so, please approve and merge when you get a change.