hackforla / HomeUniteUs

We're working with community non-profits who have a Host Home or empty bedrooms initiative to develop a workflow management tool to make the process scalable (across all providers), reduce institutional bias, and effectively capture data.
https://homeunite.us/
GNU General Public License v2.0
39 stars 21 forks source link

Initial incubator resources for container build #819

Closed tylerthome closed 1 month ago

tylerthome commented 1 month ago

Completes some items from #627

What changes did you make?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

N/A

tylerthome commented 1 month ago

gunicorn is not a dependency anymore and I can't see where it's being installed. You might be able to get away with running the fastapi run app/main.py --port 8000 command instead.

Good call @paulespinosa - I made this change as you suggested. It's using a virtual env there now because there was an issue running either of the fastapi and uvicorn commands as such in the entrypoint.sh. They could run with poetry run but this caused module references to fail while resolving from import paths. This approach worked as expected in the incubator deployment currently running at https://qa.homeunite.us, but open to any alternative approaches if this looks familiar to anyone.

paulespinosa commented 1 month ago

gunicorn is not a dependency anymore and I can't see where it's being installed. You might be able to get away with running the fastapi run app/main.py --port 8000 command instead.

Good call @paulespinosa - I made this change as you suggested. It's using a virtual env there now because there was an issue running either of the fastapi and uvicorn commands as such in the entrypoint.sh. They could run with poetry run but this caused module references to fail while resolving from import paths. This approach worked as expected in the incubator deployment currently running at https://qa.homeunite.us, but open to any alternative approaches if this looks familiar to anyone.

It looks good. Nothing off the top of my head can think of doing it any other way. Nice work!