Update HTML components to MUI: ./src/components/admin/reports/index.js

JackHaeg commented 2 months ago

Overview

Review all components in./src/components/admin/reports/index.js and replace all standard HTML components with applicable MUI components.

Action Items

[x] Review components in:./src/components/admin/reports/index.js and search for any standard HTML components.
- IF all components are already updated to relevant MUI
- [ ] Comment on this issue that all components are already updated to MUI.
- [ ] Close the issue & check the box associated with this issue on the MUI issue epic
- [ ] Move on to the next MUI issue
- IF standard HTML components are found in the file:
- [x] Replace these standard HTML components with applicable MUI components.
- [x] Make a PR for this file

Resources

https://mui.com/base-ui/all-components/
If you run into any questions, add a comment to the issue and tag "@trillium"

JackHaeg commented 1 month ago

@nora-zajzon I noticed that this issue was moved to "Done" a few weeks ago following your PR, however I can see that the PR was closed & not merged. Given that, should we move this issue back to "In Progress" or the Prioritized Backlog?

In general, we typically prefer to allow for the Github automation to close the issue & move it to the "Done" column once the PR has successfully merged.

nora-zajzon commented 1 month ago

Hi @JackHaeg Sorry about that! I messaged another team member a while back wondering whose job it is to move the columns. They did not mention that you were in charge of moving columns. I also noticed that In-Progress says that you can only work on one at a time, but some of my PR's were waiting a little while so I moved on to other issues. I have 2 PR's waiting now, I think one was approved. So, the first issue should be able to be moved into "Done" and the other two into "In-Progress" I guess? I moved them back into Prioritized Backlog for now. Thank you for bringing this to my attention.

JackHaeg commented 1 month ago

@nora-zajzon No worries whatsoever! Ideally, devs should only be working on one issue at a time. However, if you are working on an issue and have submitted the PR, then please leave the issue in the "In Progress" column until the PR is approved. Once it is approved the GitHub automation will close the associated issue & move it to the Done column on its own. You can have multiple issues being worked on at once if you'd like.

The "Prioritized Backlog" column is supposed to only be reserved for issues that are unassigned and are not being worked on - these are the issues that are available for devs to pick from. So, if you have other issues that you are working on and are awaiting PR approval, please leave them in the "In Progress" column for now until they are approved. If you have moved any issues that are awaiting PR review to the Prioritized Backlog, please move them back to "In Progress"

Also, it looks like there are currently 3 PRs for you that are awaiting approval. So I don't believe there should be any of your issues in the "Done" column as of yet (other than the "Onboarding" issue).

trillium commented 1 month ago

Closing as unplanned (this component isn't used in our current iteration of the app)

@nora-zajzon We will still happily take your PR :)

hackforla / VRMS