hackforla / VRMS

Volunteer Relationship Management System: This is an ambitious project to create a system that will help us measure our human capital development, reduce repetitive tasks and processes, and improve outcomes.
GNU Affero General Public License v3.0
40 stars 79 forks source link

Add search functionality for use-permission-search and link it to the user profile #1810

Open vorleakyek opened 1 week ago

vorleakyek commented 1 week ago

Fixes #1754

What changes did you make and why did you make them ?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied ![image](https://github.com/user-attachments/assets/2aef19a7-7457-4e98-a128-4a6e4fe174f1)
Visuals after changes are applied ![image](https://github.com/user-attachments/assets/b1dcbbcf-75a3-4969-b50b-e3cbe81e957b)
github-actions[bot] commented 1 week ago

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b vorleakyek-filtered-permission-1754 development
git pull https://github.com/vorleakyek/VRMS.git filtered-permission-1754
vorleakyek commented 3 days ago

@pluto-bell, Thanks for taking a look! Currently, I have to use the "user" data for the search function to check the link to the user profile. Using the "dummyData" won't work for the link. The search result for project leads is empty because "users" data does not seem to have accessLevel: 'projectLead'. I brought this up in #1808 PR. We probably have to deal with it as part of #1801.

But, changing "users" to "dummyData" in the UserPermissionSearch.jsx should work for the project leads search. Let me know if you have any questions.

// NOTE: Using "users" instead of "dummyData" to check the link to user profile
filteredData = getFilteredData(users, searchText, userType);

@trillium, should I change the "users" to "dummyData" in this PR or it's okay to leave it since we will have to deal with it as part of the next ticket?