Add .toLowerCase db query

hackforla / VRMS

Volunteer Relationship Management System: This is an ambitious project to create a system that will help us measure our human capital development, reduce repetitive tasks and processes, and improve outcomes.

GNU Affero General Public License v3.0

40 stars 79 forks source link

Add .toLowerCase db query #1811

Open pluto-bell opened 1 week ago

pluto-bell commented 1 week ago

Fixes #1464

What changes did you make and why did you make them ?

Added .toLowerCase() across front-end files that were calling or creating emails. If you try to sign in with various uppercase and lowercase letters, your email is now still recognized; New users emails should all resolve to lowercase to help stop duplicates.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Screen Capture - Login Example

First example shows fix, second example shows bug https://github.com/user-attachments/assets/38ebbe3d-112c-437a-8e30-0dd408f020aa

pluto-bell commented 1 week ago

Note/Question

I noticed I could create new users with invalid emails and that there is no created issue for this bug. I originally created a fix but removed it incase I'm not supposed to handle additional bugs this way.

Should I submit a new issue instead of adding the fix here?

github-actions[bot] commented 1 week ago

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b pluto-bell-add-tolowercase-db-query development
git pull https://github.com/pluto-bell/VRMS.git add-tolowercase-db-query