hackforla / VRMS

Volunteer Relationship Management System: This is an ambitious project to create a system that will help us measure our human capital development, reduce repetitive tasks and processes, and improve outcomes.
GNU Affero General Public License v3.0
40 stars 79 forks source link

add form validation for zoom google meet #1812

Open angela-lee1 opened 1 week ago

angela-lee1 commented 1 week ago

Fixes #1511

What changes did you make and why did you make them ?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied ![image]( ![Screenshot 2024-11-12 at 2 22 43 PM](https://github.com/user-attachments/assets/d87b94e6-1ae6-4c10-87e5-4bea1d9da910) )
Visuals after changes are applied ![image]( ![Screenshot 2024-11-12 at 8 55 37 PM](https://github.com/user-attachments/assets/5dffb768-5ece-48b8-84c1-0cce0d497bab) )
github-actions[bot] commented 1 week ago

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b angela-lee1-add-form-validation-zoom-google-meet development
git pull https://github.com/angela-lee1/VRMS.git add-form-validation-zoom-google-meet
angela-lee1 commented 4 days ago

@nora-zajzon, for Google Meet: Did you have a link like https://meet.google.com/bgc-szbm-osr? I was able to add it. Can you retry? For the Zoom meeting: At the moment, the Zoom regex won't match Zoom meeting URLs with a subdomain like ucsd. Will HackforLA use Zoom meetings with subdomains? I can add that. Hope this helps, and thank you for reviewing my PR.

Hi @JackHaeg and @trillium, do we allow users to enter relative URLs (those that omit https://)? Also, do we permit users to use Zoom meeting URLs with subdomains? I will move forward based on your feedback.

Screenshot 2024-11-17 at 6 46 19 PM Screenshot 2024-11-17 at 6 46 05 PM

Screenshot 2024-11-17 at 7 07 46 PM Screenshot 2024-11-17 at 7 07 56 PM

trillium commented 3 days ago

Do we allow users to enter relative URLs (those that omit https://)?

Yes, please allow for the https:// to be ommitted, as well as www.

Also, do we permit users to use Zoom meeting URLs with subdomains?

Also yes

Thanks for asking for clarification!