Open angela-lee1 opened 1 week ago
Want to review this pull request? Take a look at this documentation for a step by step guide!
From your project repository, check out a new branch and test the changes.
git checkout -b angela-lee1-add-form-validation-zoom-google-meet development
git pull https://github.com/angela-lee1/VRMS.git add-form-validation-zoom-google-meet
@nora-zajzon, for Google Meet: Did you have a link like https://meet.google.com/bgc-szbm-osr? I was able to add it. Can you retry? For the Zoom meeting: At the moment, the Zoom regex won't match Zoom meeting URLs with a subdomain like ucsd. Will HackforLA use Zoom meetings with subdomains? I can add that. Hope this helps, and thank you for reviewing my PR.
Hi @JackHaeg and @trillium, do we allow users to enter relative URLs (those that omit https://)? Also, do we permit users to use Zoom meeting URLs with subdomains? I will move forward based on your feedback.
Yes, please allow for the https://
to be ommitted, as well as www.
Also yes
Thanks for asking for clarification!
Fixes #1511
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
![image]( ![Screenshot 2024-11-12 at 2 22 43 PM](https://github.com/user-attachments/assets/d87b94e6-1ae6-4c10-87e5-4bea1d9da910) )Visuals after changes are applied
![image]( ![Screenshot 2024-11-12 at 8 55 37 PM](https://github.com/user-attachments/assets/5dffb768-5ece-48b8-84c1-0cce0d497bab) )